Sort Order for Adm Userlist incompatible with latest release

[Sylver Cheetah 53]

Hy!

I am new, so please be kind.
Your MOD Save Admin Userlist Sort Order for Admin Userlist is not updated for the latest Admin Userlist release (2.0.6).
You ask to find in admin_userlist.php this:

Code: Select all

if ( isset($HTTP_GET_VARS['sort']) || isset($HTTP_POST_VARS['sort']) )
{
   $sort = ( isset($HTTP_POST_VARS['sort']) ) ? htmlspecialchars($HTTP_POST_VARS['sort']) : htmlspecialchars($HTTP_GET_VARS['sort']);
   $sort = str_replace("\'", "''", $sort);
}
else
{
   $sort = 'user_regdate';
}

//
// sort order
//
if( isset($HTTP_POST_VARS['order']) )
{
   $sort_order = ( $HTTP_POST_VARS['order'] == 'ASC' ) ? 'ASC' : 'DESC';
}
else if( isset($HTTP_GET_VARS['order']) )
{
   $sort_order = ( $HTTP_GET_VARS['order'] == 'ASC' ) ? 'ASC' : 'DESC';
}
else
{
   $sort_order = 'ASC';
}

But we got this:

Code: Select all

if ( isset($HTTP_GET_VARS['sort']) || isset($HTTP_POST_VARS['sort']) )
{
   $sort = ( isset($HTTP_POST_VARS['sort']) ) ? htmlspecialchars($HTTP_POST_VARS['sort']) : htmlspecialchars($HTTP_GET_VARS['sort']);
   $sort = str_replace("\'", "''", $sort);
}
else
{
   $sort = 'user_regdate';
}
switch( $sort )
{

   case 'username':
   case 'user_regdate':
   case 'user_session_time':
   case 'user_level':
   case 'user_posts':
   case 'user_rank':
   case 'user_email':
   case 'user_website':
   case 'user_active':
   break;
   default:
   $sort = "user_regdate";
   break;
}

//
// sort order
//
if( isset($HTTP_POST_VARS['order']) )
{
   $sort_order = ( $HTTP_POST_VARS['order'] == 'ASC' ) ? 'ASC' : 'DESC';
}
else if( isset($HTTP_GET_VARS['order']) )
{
   $sort_order = ( $HTTP_GET_VARS['order'] == 'ASC' ) ? 'ASC' : 'DESC';
}
else
{
   $sort_order = 'DESC';
}

In userlist_body.tpl, you ask us to find this:

Code: Select all

         <option value="user_id">{L_USER_ID}</option>
         <option value="user_active">{L_ACTIVE}</option>
         <option value="username">{L_USERNAME}</option>
         <option value="user_regdate">{L_JOINED}</option>
         <option value="user_session_time">{L_ACTIVTY}</option>
         <option value="user_level">{L_USER_LEVEL}</option>
         <option value="user_posts">{L_POSTS}</option>
         <option value="user_rank">{L_RANK}</option>
         <option value="user_email">{L_EMAIL}</option>
      </select></td>
      <td nowrap="nowrap"><select name="order" class="post">
         <option value="ASC">{L_ASCENDING}</option>
         <option value="DESC">{L_DESCENDING}</option>

But what we got is this:

Code: Select all

<td class="{user_row.ROW_CLASS}" nowrap="nowrap"><input type="checkbox" name="{S_USER_VARIABLE}[]" value="{user_row.USER_ID}" /></td>
      <td class="{user_row.ROW_CLASS}" nowrap="nowrap"><span id="oI[]" onClick="javascript:handleClick('{user_row.USER_ID}');"><div id="{user_row.USER_ID}" name="oF[]">{ARROWRIGHT_IMG}</div></span></td>
      <td class="{user_row.ROW_CLASS}"><span class="gen" {user_row.STYLE_COLOR}><b><a href="{user_row.U_MANAGE}" class="gen" {user_row.STYLE_COLOR}>{user_row.USERNAME}</a></b></span></td>
      <td class="{user_row.ROW_CLASS}"><span class="gen">{user_row.ACTIVE}</span></td>
      <td class="{user_row.ROW_CLASS}"><span class="gen">{user_row.JOINED}</span></td>
      <td class="{user_row.ROW_CLASS}"><span class="gen">{user_row.LAST_ACTIVITY}</span></td>
      <td class="{user_row.ROW_CLASS}"><span class="gen">{user_row.POSTS}</span></td>
      <td class="{user_row.ROW_CLASS}"><a href="{user_row.U_WEBSITE}" class="gen" target="_blank">{user_row.U_WEBSITE}</a></td>
      <td class="{user_row.ROW_CLASS}"><a href="mailto:{user_row.EMAIL}" class="gen">{user_row.EMAIL}</a></td>
   </tr>

Please take a look at the latest Admin Userlist release, and update your addon. Please!
Thanks!

[TerraFrost]

That's actually for Admin Userlist - not for SQL Backup

Anyway, I actually sorta consider my phpBB2 MODs to be abandoned. With the closure of the phpbb.com phpBB2 forum, there's no one centralized source for getting support or for keeping track of outstanding support requests. Also, I'd just assume not be bogged down with phpBB2 MODs when phpBB3 MODs await creation - if you don't abandon things, periodically, than someone who's been doing open source for quite a while won't ever have the time to start new projects - all they'll ever be doing is supporting existing ones.

Anyway, try posting on http://www.phpbb2refugees.com/index.php . Good luck!

[Sylver Cheetah 53]

Thanks for your reply!

Yes. My bad. I installed Admin Userlist and SQL Backup in the same day (yesterday) and I was confused. I was reffering to Admin Userlist, indeed.

To be honnest, I know about PhpBB2Refugees, but I'm not satisfyed by the way users are trated. I will try to find help somewhere else... then.

Too bad people let phpBB2 go down... I still consider it the best bulletin board.
Daniel (Romania)

[TerraFrost]

Hmm - phpbbhacks.com might be able to help out, then.

Also, the orig. MOD Author (although I think that MOD has changed hands quite a few times, heh) might be willing to incorporate the feature if asked. Indeed, I actually thought one of the validated versions did include that feature, heh.